Generalizing minimal initializers #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinuzziFrancesco
changed the title
Collaborator
Author
|
I think that we can generalize the minimal reservoir inits even more now by also having some random sign changes there. For this we need to format function bernoulli!(rng::AbstractRNG, vecormat::AbstractVecOrMat; p::Number=0.5)
for idx in eachindex(vecormat)
if rand(rng) > p # keeping current approach consistent
vecormat[idx] = - vecormat[idx]
end
end
endand then having the option to change signs in the inits functions like so function delay_line!(rng::AbstractRNG, reservoir_matrix::AbstractMatrix, weight::AbstractVector,
shift::Int; sampling_type=:default, kwargs...) # :bernoulli, :irrational
for idx in first(axes(reservoir_matrix, 1)):(last(axes(reservoir_matrix, 1)) - shift)
reservoir_matrix[idx + shift, idx] = weight[idx]
end
f_sample = getfield(@__MODULE__, sampling_type)
f_sample!(rng, reservoir_matrix; kwargs...)
end |
MartinuzziFrancesco
changed the title
Collaborator
Author
|
Not really sure why docs are failing, locally they compile just fine. @ChrisRackauckas I can't access the buildkite log it seems, is there any way to get access? |
Member
|
Pipeline is public now. |
Collaborator
Author
|
Awesome, thanks |
Collaborator
Author
|
I'm getting and it doesn't allow me to relaunch the workflow |
Collaborator
Author
|
all seems to be fine now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Closes #265. I am thinking if the building pieces need to be user facing too. I need to update existing documentation to reflect the new flexibility of the initializers (option of using vector of values for
weight). Add docstrings to the building pieces too if they become public api.